Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::iterator_adaptor with explicitly specified iterator definition for Usd_PrimData{Sibling,Subtree}Iterator #2235

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Feb 1, 2023

Description of Change(s)

  • Introduces an _UnderlyingIterator type alias for Usd_PrimData* in Usd_PrimDataSiblingIterator and Usd_PrimDataSubtreeIterator
  • Elides implementing operator-> for these internal types as it is currently not used. As the reference type is not a true reference, a spurious proxy class would be required to properly support pointer semantics.
  • Explicitly implements the increment, dereference, equality and arrow operators for Usd_PrimDataSiblingIterator and Usd_PrimDataSubtreeIterator

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7963

@nvmkuruc nvmkuruc force-pushed the usdprimdataadaptor branch from 6b13e36 to 3594c42 Compare April 18, 2023 19:42
@pixar-oss pixar-oss merged commit 40f0551 into PixarAnimationStudios:dev Jul 27, 2023
@nvmkuruc nvmkuruc deleted the usdprimdataadaptor branch December 29, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants